-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v4.1.0 #6076
Release v4.1.0 #6076
Conversation
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
✅ docs built successfully: https://readthedocs.org/projects/lightgbm/builds/21819866/ ✅ and look good to me: https://lightgbm.readthedocs.io/en/release-v4.1.0/ |
The R package passed on an M1 Mac Mini: https://mac.r-project.org/macbuilder/results/1689263124-d89c2bc709b122ea/. |
I will test the Python package on my M2 mac laptop tonight. If that passes, then I think this is ready to release! @shiyu1994 @guolinke @jmoralez Could you please review this and approve if you agree with releasing the current state of |
Tested the Python package on my M2 Mac laptop today. I had to run without OpenMP support (a documented issue in #4229 and #5764), but otherwise LightGBM compiled successfully and the Python tests passed. I'll try to work on those issues for the next release. So with that.... I think we are ready to release! @jmoralez since this has been up for a couple days and since both @guolinke and @shiyu1994 have approved, I won't wait for your approval... I'll merge this later today, once CI passes unless we hear any objections from you before then. |
Thanks everyone! I'll merge this and start on the other release tasks. Please don't merge anything else for the next few hours...so the automatic changelog won't get corrupted. |
Ran the following to create the git fetch upstream --tags
git tag -d stable
git push upstream :refs/tags/stable
git tag stable v4.1.0
git push upstream stable v4.1.0 (NOTE: I alias this repo to https://github.com/microsoft/LightGBM/tags That triggered an Azure DevOps build which should create the release automatically: https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=15169&view=results. This takes around 90 minutes (because of the QEMU CI job). NOTE: I messed this up last time. In v4.0.0, I directly published the ... while all the others have @guolinke . Sorry about that! I won't make that mistake again. |
This is done. Passing build: https://readthedocs.org/projects/lightgbm/builds/21891719/ Docs: https://lightgbm.readthedocs.io/en/v4.1.0/ |
Put up #6090 |
Uploaded v4.1.0 wheels and sdist to PyPI 😁 https://pypi.org/project/lightgbm/4.1.0/ |
This is done |
Someone else already put up a PR for this: Homebrew/homebrew-core#142052 |
I think all tasks are complete, and this release is done! Thanks so much for the help everyone, and especially @shiyu1994 for the suggestion. I'm very happy that we might start doing smaller, more frequent releases of LightGBM, and I think the project's users will be too 😁 |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Release checklist:
Copied from #5952, with a few changes.
before merge
configure
file of R-package:/gha run r-configure
.development.mode
fromunreleased
torelease
in pkgdown config file.python-package/pyproject.toml
versionadded::
annotations (docs on those)config.h
have*New in version {version}*
comments added/gha run r-valgrind
(docs link)PRs that should be merged before releasing:
None.
after merge
v*
tag to triggerGitHubRelease
action at Azure Pipelines.release-drafter
to the automatically-created GitHub release, convert it fromDraft
to published.stable
tag at GitHub.[ ] Upload release to CRAN.[ ] Update cran-comments.md when new release is accepted on CRAN.Notes for Reviewers
I believe this should be
v4.1.0
instead ofv4.0.0
because of the addition of position-bias correction for learning-to-rank: #5929.This release of the R package will not be published to CRAN, as #5987 has still not been resolved. I'll prioritize that and maybe we'll be able to release the next version to CRAN.